Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-pipes-rust] - Add support for closing the pipes context #71

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

marijncv
Copy link
Collaborator

Summary & Motivation

This adds the ability to close the pipes context by sending a closing message with optional exception information. It also implements the Drop trait for the PipesContext to automatically send the closing message when the context goes out of scope

How I Tested These Changes

Added tests

Changelog

Ensure that an entry has been created in CHANGELOG.md outlining additions, deletions, and/or modifications.

See: keepachangelog.com

Copy link
Collaborator

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really clever!

@cmpadden cmpadden merged commit 9c0528d into main Dec 29, 2024
3 checks passed
@cmpadden cmpadden deleted the close-pipes-context branch December 29, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants